This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix intermittent fork test failure in develop #9937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This is to merge #9930 into
develop
branch.https://blockone.atlassian.net/browse/EPE-465
When building the list of blocks to search for forking, the range was
for blockNum in
range(preKillBlockNum, lastBlockNum)
. In Python, the range is half closed. This results in an off by one problem if the forking block was the exact lastBlockNum. In EPE-465,lastBlockNum
and the forked block number both ware 166, but the search ended t 165. This is also why the problem occurs rarely. The fix isfor blockNum in range(preKillBlockNum, lastBlockNum + 1)
Fix the problem in both
nodeos_forked_chain_test.py
andnodeos_short_fork_take_over_test.py
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions