This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Rocksdb rpc support #9685
Merged
Rocksdb rpc support #9685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c key to be processed
…c key to be processed
heifner
previously requested changes
Nov 19, 2020
libraries/chain/include/eosio/chain/backing_store/db_combined.hpp
Outdated
Show resolved
Hide resolved
libraries/chain/include/eosio/chain/backing_store/db_combined.hpp
Outdated
Show resolved
Hide resolved
libraries/chain/include/eosio/chain/backing_store/db_combined.hpp
Outdated
Show resolved
Hide resolved
libraries/chain/include/eosio/chain/backing_store/db_combined.hpp
Outdated
Show resolved
Hide resolved
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
plugins/history_plugin/include/eosio/history_plugin/public_key_history_object.hpp
Show resolved
Hide resolved
Sorry, I missed this one. Added. |
…e) in state_history_tests.cpp
libraries/chain/include/eosio/chain/backing_store/db_combined.hpp
Outdated
Show resolved
Hide resolved
libraries/chain/include/eosio/chain/backing_store/db_combined.hpp
Outdated
Show resolved
Hide resolved
…ded truncate_key static method to replace use case of previous, also added some excceptions for invalid queries
brianjohnson5972
suggested changes
Nov 25, 2020
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
brianjohnson5972
approved these changes
Nov 25, 2020
brianjohnson5972
dismissed
heifner’s stale review
I verified all of Kevin's issues, but it wants him to approve, so removing his review.
|
Financial help
Please help out
…On Wed, Nov 25, 2020, 23:18 Victor Camacho ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In libraries/chain_kv/unit_tests/shared_bytes_tests.cpp
<#9685 (comment)>:
> + static constexpr auto* a_value = "a";
+ static constexpr auto* a_next_expected = "b";
+ auto a = shared_bytes(a_value, 1);
+ BOOST_REQUIRE(memcmp(a.next().data(), reinterpret_cast<const int8_t*>(a_next_expected), 1) == 0);
+ BOOST_REQUIRE(a.next().size() == 1);
+
+ static constexpr auto* aa_value = "aa";
+ static constexpr auto* aa_next_expected = "ab";
+ auto aa = shared_bytes(aa_value, 2);
+ BOOST_REQUIRE(memcmp(aa.next().data(), reinterpret_cast<const int8_t*>(aa_next_expected), 2) == 0);
+ BOOST_REQUIRE(aa.next().size() == 2);
+
+ static constexpr auto* empty_value = "";
+ auto empty = shared_bytes(empty_value, 0);
+ BOOST_CHECK_THROW(empty.next().size(), eosio::chain::chain_exception);
+
Done
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9685 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJD44LTU4QNO5PQSGM4AZWLSRVRCHANCNFSM4TZLLFSA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Credit: All the coding in the PR was done by Brian Johnson; thanks!
This PR adds RPC support over RocksDb backing store. I have tested with various
cleoscommandsget scope,get account,get currency,get table,create account,issue tokens, andtransfer tokens.They all worked,The goal is to get this into
developso we can fix remaining issues using smaller PRs.Known issue:
system listproducersdoes not work on RocksDb but works on Chainbase,Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions