Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add "Testing Changes" Section to Pull Request Template #9662

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Conversation

kj4ezj
Copy link
Contributor

@kj4ezj kj4ezj commented Nov 13, 2020

Change Description

From EPE-486 and AUTO-311, I was asked to add testing checkboxes to the pull request template for EOSIO:

## Testing Changes
- [ ] New Tests
- [ ] Existing Tests
- [ ] Test Framework
- [ ] CI System
- [ ] Other

This benefits Blockchain by encouraging developers to consider test cases while writing pull requests and submitting new contributions. This benefits Automation by providing a convenient programmatic way to detect, track, notify, or act upon changes to the CI system or test framework(s), like we do with the other check boxes. More broadly, we all stand to benefit from a culture more focused on testing.

The new template has been manually pasted into this pull request so you can see what it looks like, but GitHub will not present the new template to users until it is merged to this repository's default branch:

You must create templates on the repository's default branch. Templates created in other branches are not available for collaborators to use.

See the Pull request templates heading on the About issue and pull request templates page of GitHub's documentation for more information.

See Also

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other

Pull request template.

  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

None.

Consensus Changes

  • Consensus Changes

None.

API Changes

  • API Changes

None.

Documentation Additions

  • Documentation Additions

None.

@kj4ezj kj4ezj merged commit 961f26b into develop Nov 13, 2020
@kj4ezj kj4ezj deleted the zach-template branch November 13, 2020 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants