This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Migrate CI from Docker Hub to Amazon ECR #9623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing only dockerhub.
…to FORCE_BASE_IMAGE='true'
This was referenced Nov 6, 2020
7 tasks
scottarnette
approved these changes
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
From AUTO-301.
Background
On Monday, 2020-11-02, docker will be rate-limiting
GET
requests for image manifests (functionally, image pulls) by IP address to 200req/6hr authenticated or 100req/6hr unauthenticated. See the heading of this blog post entitled “Reminder: Image pull consumption tiers,” and this FAQ.Problem
We use docker hub to store CI images for EOSIO. Each eosio or eosio-build-unpinned build performs ~100 jobs, each with one or two image manifest requests to docker hub. While the instances (and thus IP addresses) being used by our buildfleet does rotate regularly, rotation is not guaranteed between builds and is unlikely during periods of high use where we retain a large node fleet churning through Buildkite jobs. These new manifest query limits could be encountered with as little as one build, rendering the CI system unusable.
Solution
The CI system will push images to both docker hub and to Amazon ECR in-parallel, and pull exclusively from Amazon ECR. This retains the ability for the CI system to perform unlimited pulls without interrupting service to any downstream consumers of docker hub images containing EOSIO environments or installations generated by our CI system.
Other solutions considered:
See Also
0ea4ab0
-- Create docker hub mirror in ECR for CI images3d4067a
-- AWS CLI prints version information to STDERR, not STDOUT11be4dc
-- Add ECR to "buildkite_eos_jobs_policy" actionseos:develop
eos:blockvault
eos:release/2.0.x
eos:develop-boxed
eos:release/1.8.x
Change Type
Select ONE
CI
Consensus Changes
None.
API Changes
None.
Documentation Additions
None.