This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Trace API plugin - Add support for action return values #9547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The intent of this PR is to add support to the trace api plugin for a new field representing a value that may be returned by an action.
To accomplish this task 3 new structs were added:
action_trace_v1 : representing the new version of an action trace that now may contain a field representing the return value.
transaction_trace_v2: representing the new version for the transaction trace that supports action_trace_v1.
block_trace_v2: representing the new version for block trace that supports transaction_trace_v2.
The general idea is that, for example, a new version for action traces may now not require the creation of new structs for transaction trace and block trace, but only a modification to the actions type on the transaction trace struct (add a new possibility for the variant).
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions