This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Restrict the maximum number of open HTTP RPC requests #9431
+69
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1bart
suggested changes
Aug 24, 2020
b1bart
suggested changes
Aug 24, 2020
b1bart
approved these changes
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added a new option for
http-plugin:http-max-in-flight-requests. It restricts the maximum requests the flight can hold if --http-max-in-flight-requests = positive number. If the limit exceeds, it sends a 429 error to the client. if --http-max-in-flight-requests = -1, there is no limit so the feature is turned off. It protects non-producing nodeos against the flood of requests when it cannot get new blocks.Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions
Added a new http_plugin option --http-max-in-flight-requests. "--http-max-in-flight-requests = positive number" sets the limit of requests that the flight can hold. If the limit is exceeded, a 429 error is sent to the client. if --http-max-in-flight-requests = -1, the feature is turned off. The feature is turned off in default. The doc is: "Maximum number of requests http_plugin should use for processing http requests. 429 error response when exceeded."
A change is made for the http_plugin option http-max-bytes-in-flight-mb. When the limit is exceeded, the error coode is 429, instead of 503. The new doc is: "Maximum size in megabytes http_plugin should use for processing http requests. 429 error response when exceeded."