fix the bug that the flight bytes are calculated incorrectly #9411
Conversation
…flight queue size exceeds the maximum flight bytes
| @@ -448,7 +449,7 @@ namespace eosio { | |||
| */ | |||
| template<typename T> | |||
| static auto make_in_flight(T&& object, http_plugin_impl& impl) { | |||
| return in_flight<T>(std::forward<T>(object), impl); | |||
| return std::make_shared<in_flight<T>>(in_flight<T>(std::forward<T>(object), impl)); | |||
There was a problem hiding this comment.
Does this have to be a shared_ptr? Can't it just be moved into wrapped_then then when wrapped_then is destructed it will as well.
There was a problem hiding this comment.
Does this have to be a
shared_ptr? Can't it just be moved intowrapped_thenthen whenwrapped_thenis destructed it will as well.
No. Since in_flight disables its copy constructor, tracked_b gets deleted if it's not wrapped by a shared pointer.
There was a problem hiding this comment.
Move it, not copy it.
It failed to move. The error showed that it called the copy constructor, not the operator =.
There was a problem hiding this comment.
there are a few reasons why we moved this to a std::shared_ptr the first is that it makes it copyable which is necessary for use with std::function. The second is that we have multiple asynchronous paths so there was no single lifecycle for tracked_b. We are leaning on the std::shared_ptr 's reference counting to give us the lifetime guarantees we want.
gleehokie
changed the title
Change Description
There is an option for nodeos that specifies the max flight bytes. However, it did not work fine since the calculation of the bytes in flight was wrong. The bytes in flight was always 0 or 1 so it never exceeds the max flight bytes.
It causes an issue that nodeos continues to accept new transactions when there is no new blocks until the process reaches the maximum file descriptors. It causes the nodeos malfunctioning and cannot be recovered. In some environments it causes the whole OS malfunctioning.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions