Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[develop] Fix docker tags when building forked PRs #9398

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

scottarnette
Copy link
Contributor

Change Description

Some test steps in the pipeline require a built Docker container. This fixes a error with tagging the container when a forked PR is executed in Buildkite.

See:
Build 23809 | Failed build due to Docker - Build and Install step dying when tagging build using forked branch name.
Build 23834 | Docker - Build and Install step now passes when using a forked branch name.

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line must also be changed.

Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧

@scottarnette scottarnette merged commit 6d4a09e into develop Aug 13, 2020
@scottarnette scottarnette deleted the cicd-fix-forked-docker-dev branch August 13, 2020 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants