This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
develop version of "Account Query DB : maintain get_(key|controlled)_accounts" #9384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account Query DB : maintain get_(key|controlled)_accounts develop version ported from #8899
Account Query DB : maintain get_(key|controlled)_accounts port to develop from #8899
Account Query DB maintain get_(key|controlled)_accounts port to develop from #8899
Account Query DB : maintain get_(key|controlled)_accounts port to develop from #8899
|
FYI, if you cherry-pick it makes it easier to verify parity with other branch. Also the original PR has better descriptions on the commits which would be preserved with cherry-pick; not to mention it also preserves attribution. |
|
#9382 is fixing some bugs and adding unit tests and we should adopt those changes into this PR before official review/merge |
Reorganize some code in the source file to better simulate the real integration
ndcgundlach
approved these changes
Aug 26, 2020
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This is the develop version of "Account Query DB : maintain get_(key|controlled)_accounts" (#8899) created to maintain feature parity with Release/2.0.x. It also includes the fix from #9129 and #9382
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions