This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add Ubuntu 20.04 cicd dockerfiles/buildscripts-develop #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndcgundlach
changed the title
|
I kicked off eosio-build-scripts build 558 to test those YAML changes. |
kj4ezj
suggested changes
Aug 10, 2020
There was a problem hiding this comment.
I recommended approaching this story by copying the Ubuntu 18.04 dockerfiles to create Ubuntu 20.04 dockerfiles, which you have done.
Unfortunately, the existing dockerfiles follow a few anti-patterns that I do not believe we should reuse. These are described below. You are free to remove these patterns from all of the dockerfiles, however, this peer-review is only concerned with the new ones.
kj4ezj
previously requested changes
Aug 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add docker files and build script entries for Ubuntu 20.04.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions