Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update abieos submodule to point to eosio branch #9347

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

emorybarlow
Copy link
Contributor

Change Description

Update abieos submodule to point to eosio branch

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@linhuang-blockone linhuang-blockone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I could not hover over lines where I could add a comment.
Here are my two general comments:

  1. I am a little concern that "#ifndef ABIEOS_NO_INT128" scatters around files. Do we want to keep this as an option or just keep it on?
  2. Do we have test cases for ABIEOS_NO_INT128 being both turned on and off?

@emorybarlow
Copy link
Contributor Author

I don't know why I could not hover over lines where I could add a comment.
Here are my two general comments:

  1. I am a little concern that "#ifndef ABIEOS_NO_INT128" scatters around files. Do we want to keep this as an option or just keep it on?
  2. Do we have test cases for ABIEOS_NO_INT128 being both turned on and off?

I did not make those changes so I’ll defer comment to @tbfleming . This PR is just to update the submodule.

@tbfleming
Copy link
Contributor

It varies by architecture:

  • x86-64 compilers support 128-bit
  • wasm compilers support 128-bit
  • iOS and Android compilers don't

The default supports 128-bit.

@tbfleming
Copy link
Contributor

The tests build in the same mode as the library. The only real way to test iOS and Android compatibility is to build abieos for those platforms and integrate into an iOS or Android test bench (probably an emulator).

Copy link
Contributor

@linhuang-blockone linhuang-blockone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@emorybarlow emorybarlow merged commit 3bab3de into develop Jul 30, 2020
@jeffreyssmith2nd jeffreyssmith2nd deleted the update-abieos branch July 30, 2020 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants