This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix for connection cycle not being in sync with test startup. #9164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiszczak
previously requested changes
Jun 1, 2020
huangminghuang
approved these changes
Jun 2, 2020
brianjohnson5972
dismissed
jgiszczak’s stale review
Addressed changes and Huang-Ming verified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Test restarts several nodes at the same time, which occasionally leads to connection cycle being delayed to the next pass, which is 30 seconds later, so test was failing. Added extra time to wait for lib to start moving.
Consensus Changes
API Changes
Documentation Additions