Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Exit on rodeos filter wasm error #9117

Merged
merged 3 commits into from
May 22, 2020
Merged

Conversation

heifner
Copy link
Contributor

@heifner heifner commented May 19, 2020

Change Description

  • Report filter wasm exceptions as errors so it is clear exception is from the filter wasm.
  • Add option clone-exit-on-filter-wasm-error to cloner_plugin which is part of rodeos defaults to false. If enabled, it will shutdown rodeos on error.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

  • New rodeos option clone-exit-on-filter-wasm-error - Shutdown application if filter wasm throws an exception

@heifner heifner requested a review from tbfleming May 19, 2020 22:12
@b1bart
Copy link
Contributor

b1bart commented May 20, 2020

Is retry logic scoped for rodeos before a public alpha/beta release? or is the long-term expectation that failure equates to "halt and catch fire"

@heifner
Copy link
Contributor Author

heifner commented May 20, 2020

Is retry logic scoped for rodeos before a public alpha/beta release? or is the long-term expectation that failure equates to "halt and catch fire"

@tbfleming

@heifner heifner merged commit da6230e into develop May 22, 2020
@heifner heifner deleted the rodeos-filter-wasm-error-exit branch May 22, 2020 13:05
@tbfleming
Copy link
Contributor

If a wasm fails, retrying it would get the same result, so it doesn't. Unless there's a determinism bug...

It retries when there's a ship connection failure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants