Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add help text to wasm-runtime - develop #9020

Merged
merged 14 commits into from
May 13, 2020
Merged

Conversation

kimjh2005
Copy link
Contributor

@kimjh2005 kimjh2005 commented Apr 28, 2020

#8945 Help text for --wasm-runtime does not show available

Change Description

This change adds available wasm-runtime options in nodeos help.
nodeos --help

Old help text
--wasm-runtime runtime Override default WASM runtime

New help text
--wasm-runtime runtime (=eos-vm-jit) Override default WASM runtime (
"eos-vm-jit", "eos-vm", ["eos-vm-oc"]) "eos-vm-jit" : A WebAssembly runtime
that compiles WebAssembly code to native x86 code prior to execution.
"eos-vm" : A WebAssembly interpreter.
"eos-vm-oc" : Unsupported. Instead, use one of the other runtimes along with the option enable-eos-vm-oc

*Note: The option and the text for "eos-vm-oc" only appears in help text when EOSIO_EOS_VM_DEVELOPER is defined.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@kimjh2005 kimjh2005 marked this pull request as ready for review April 28, 2020 21:29
plugins/chain_plugin/chain_plugin.cpp Outdated Show resolved Hide resolved
plugins/chain_plugin/chain_plugin.cpp Outdated Show resolved Hide resolved
plugins/chain_plugin/chain_plugin.cpp Outdated Show resolved Hide resolved
@kimjh2005 kimjh2005 requested a review from heifner May 1, 2020 17:55
@heifner heifner requested a review from lparisc May 7, 2020 12:39
Copy link
Contributor

@lparisc lparisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update the --wasm-help option in the docs. Btw lots of commits here... rebase issue?

@kimjh2005
Copy link
Contributor Author

I had run "git rebase develop" because of the "Git submodule Regression check" failure.
There was no code changes.

Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean this up, not comfortable merging as is.

@heifner heifner changed the base branch from develop to master May 7, 2020 18:35
@heifner heifner changed the base branch from master to develop May 7, 2020 18:35
Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the base in PR which fixed the large diff.

plugins/chain_plugin/chain_plugin.cpp Outdated Show resolved Hide resolved
@heifner heifner changed the title add help text to wasm-runtime add help text to wasm-runtime - develop May 8, 2020
@kimjh2005 kimjh2005 merged commit 118efbd into develop May 13, 2020
@kimjh2005 kimjh2005 deleted the 8945-help-text-wasm-runtime branch May 14, 2020 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants