This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
add help text to wasm-runtime - develop #9020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Apr 29, 2020
spoonincode
reviewed
Apr 29, 2020
heifner
reviewed
May 4, 2020
heifner
reviewed
May 4, 2020
heifner
approved these changes
May 7, 2020
lparisc
reviewed
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update the --wasm-help option in the docs. Btw lots of commits here... rebase issue?
I had run "git rebase develop" because of the "Git submodule Regression check" failure. |
heifner
suggested changes
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean this up, not comfortable merging as is.
heifner
approved these changes
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the base in PR which fixed the large diff.
3 tasks
spoonincode
suggested changes
May 8, 2020
heifner
changed the title
add help text to wasm-runtime
add help text to wasm-runtime - develop
May 8, 2020
spoonincode
approved these changes
May 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8945 Help text for
--wasm-runtime
does not show availableChange Description
This change adds available wasm-runtime options in nodeos help.
nodeos --help
Old help text
--wasm-runtime runtime Override default WASM runtime
New help text
--wasm-runtime runtime (=eos-vm-jit) Override default WASM runtime (
"eos-vm-jit", "eos-vm", ["eos-vm-oc"]) "eos-vm-jit" : A WebAssembly runtime
that compiles WebAssembly code to native x86 code prior to execution.
"eos-vm" : A WebAssembly interpreter.
"eos-vm-oc" : Unsupported. Instead, use one of the other runtimes along with the option enable-eos-vm-oc
*Note: The option and the text for "eos-vm-oc" only appears in help text when EOSIO_EOS_VM_DEVELOPER is defined.
Consensus Changes
API Changes
Documentation Additions