This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
chain_api_plugin swagger file - develop #8494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskvr
added
chain-api-v2
documentation
Requires attention from documentation team. e.g. documentation is expected to be generated.
and removed
chain-api-v2
labels
Jan 23, 2020
jlamarr22
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some comments on things that can be removed and things that we could add. This could go in as-is though aside from updating https://github.com/EOSIO/eos/pull/8494/files#diff-137adfd5ab958db3399bcbe30e57fb53R40
3 tasks
lparisc
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass locally; approving now until remaining descriptions can be added
lparisc
changed the title
chain_api_plugin swagger file
chain_api_plugin swagger file - develop
Mar 5, 2020
3 tasks
This was referenced Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
documentation
Requires attention from documentation team. e.g. documentation is expected to be generated.
needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Change Description
json-schema
from remote canonical to limit build complexity and testing surface ofEOSIO/eos
repository.TODO
Alignment with 2.0 APIstype
signatures in generators (applies to bothswagger-codegen
andopenapi-generator
though more so for the latter) move request and responses to definitions.Needs attention
get_required_keys
- No response has been definedget_currency_stats
- A response with a wildcard key can be defined*
(where*
is the symbol)Preview
https://eosio.github.io/eos/latest/nodeos/plugins/chain_api_plugin/api-reference/index#tag/Chain
Assignees
@iamveritas - Give @lparisc some good pointers and consider adding descriptions, look for
NEEDS DESCRIPTION
@lparisc - Prepare for handoff and add remaining descriptions
Review criteria
@b1bart - Technical accuracy (time permits)
@arhag - Technical accuracy (time permits)
@lparisc - Technical accuracy (supplemental) and documentation
@iamveritas - Technical accuracy (supplemental) and documentation
@jlamarr22 - Specification adherence and compatibility with generators
Consensus Changes
API Changes
Documentation Additions