Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

chain_api_plugin swagger file - develop #8494

Merged
merged 11 commits into from
Mar 16, 2020
Merged

Conversation

dskvr
Copy link
Contributor

@dskvr dskvr commented Jan 23, 2020

Work in progress

Change Description

  • Adds Chain API Swagger File.
  • Consumes OAS 3.0 compatible json-schema from remote canonical to limit build complexity and testing surface of EOSIO/eos repository.

TODO

  • ~Depends on several adjustments to existing schemata. ~
  • Alignment with 2.0 APIs
  • Some descriptions are missing Pending
  • To preserve type signatures in generators (applies to both swagger-codegen and openapi-generator though more so for the latter) move request and responses to definitions.
  • Begin to identify the describable status codes in the error ranges (the response format is currently too inconsistent for definition on many status codes)
  • Add example requests to each end-point.

Needs attention

  • get_required_keys - No response has been defined
  • get_currency_stats - A response with a wildcard key can be defined * (where * is the symbol)

Preview
https://eosio.github.io/eos/latest/nodeos/plugins/chain_api_plugin/api-reference/index#tag/Chain

Assignees
@iamveritas - Give @lparisc some good pointers and consider adding descriptions, look for NEEDS DESCRIPTION
@lparisc - Prepare for handoff and add remaining descriptions

Review criteria
@b1bart - Technical accuracy (time permits)
@arhag - Technical accuracy (time permits)
@lparisc - Technical accuracy (supplemental) and documentation
@iamveritas - Technical accuracy (supplemental) and documentation
@jlamarr22 - Specification adherence and compatibility with generators

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@dskvr dskvr changed the title Chain API Swagger File Chain API Swagger File Jan 23, 2020
@dskvr dskvr added chain-api-v2 documentation Requires attention from documentation team. e.g. documentation is expected to be generated. and removed chain-api-v2 labels Jan 23, 2020
Copy link

@jlamarr22 jlamarr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some comments on things that can be removed and things that we could add. This could go in as-is though aside from updating https://github.com/EOSIO/eos/pull/8494/files#diff-137adfd5ab958db3399bcbe30e57fb53R40

plugins/chain_api_plugin/chain.swagger.yaml Outdated Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Outdated Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Outdated Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Outdated Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Outdated Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Outdated Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Outdated Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Show resolved Hide resolved
plugins/chain_api_plugin/chain.swagger.yaml Show resolved Hide resolved
@dskvr dskvr changed the title Chain API Swagger File chain_api_plugin swagger file Feb 6, 2020
@dskvr dskvr mentioned this pull request Feb 6, 2020
3 tasks
@lparisc lparisc marked this pull request as ready for review March 4, 2020 23:13
Copy link
Contributor

@lparisc lparisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally; approving now until remaining descriptions can be added

@lparisc lparisc changed the title chain_api_plugin swagger file chain_api_plugin swagger file - develop Mar 5, 2020
@lparisc lparisc mentioned this pull request Mar 5, 2020
3 tasks
@b1bart b1bart removed their request for review March 6, 2020 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated. needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants