This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
llvm 10 support for EOS VM OC #8465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe-b1
suggested changes
Jan 22, 2020
Comment on lines
899
to
921
| #else | ||
| #define EMIT_LOAD_OP(valueTypeId,name,llvmMemoryType,naturalAlignmentLog2,conversionOp) \ | ||
| void valueTypeId##_##name(LoadOrStoreImm<naturalAlignmentLog2> imm) \ | ||
| { \ | ||
| auto byteIndex = pop(); \ | ||
| auto pointer = coerceByteIndexToPointer(byteIndex,imm.offset,llvmMemoryType); \ | ||
| auto load = irBuilder.CreateLoad(pointer); \ | ||
| load->setAlignment(llvm::MaybeAlign(1)); \ | ||
| load->setVolatile(true); \ | ||
| push(conversionOp(load,asLLVMType(ValueType::valueTypeId))); \ | ||
| } | ||
| #define EMIT_STORE_OP(valueTypeId,name,llvmMemoryType,naturalAlignmentLog2,conversionOp) \ | ||
| void valueTypeId##_##name(LoadOrStoreImm<naturalAlignmentLog2> imm) \ | ||
| { \ | ||
| auto value = pop(); \ | ||
| auto byteIndex = pop(); \ | ||
| auto pointer = coerceByteIndexToPointer(byteIndex,imm.offset,llvmMemoryType); \ | ||
| auto memoryValue = conversionOp(value,llvmMemoryType); \ | ||
| auto store = irBuilder.CreateStore(memoryValue,pointer); \ | ||
| store->setVolatile(true); \ | ||
| store->setAlignment(llvm::MaybeAlign(1)); \ | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Do you really need to duplicate the whole function just to add llvm::MaybeAlign?
swatanabe-b1
approved these changes
Jan 23, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Minor changes to update EOS VM OC to work with LLVM 10. Tested against rc1, passed all tests.
ORCv1, the LLVM API EOS VM OC is using, was expected to be removed in 10 but it has survived. Sounds like almost certain it will be removed for 11 though, so updating to the ORCv2 API will be a requirement soon.
Consensus Changes
API Changes
Documentation Additions