This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… git branch and git tag after tests have passed
…faster by skipping git checkout
…g" step faster by skipping git checkout' This reverts commit 549acc8.
zreyn
approved these changes
Dec 20, 2019
scottarnette
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❄️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This reintroduces the EOSIO sync-from-genesis test, which takes 3-5 minutes and is configured to run on every commit like the other tests. It simply starts EOSIO on each major chain, waits for LIB to advance, then passes or fails accordingly.
I have also changed how the Docker container (previously called the "Contracts Builder" or the "Contracts Base Image") is built. Previously, it was built with the package builder steps only on builds against major branches or tags. It extended build time by about 7 minutes, as the package builders run in under 3 minutes and this step runs in about 10. Now I build and install EOSIO into the Ubuntu 18.04 Docker container with the other build steps, pushing it to Docker Hub tagged with ONLY the git commit. This takes about the same amount of time as the other build steps. Later in the build, once all tests have passed, the container is retroactively tagged with the git branch and git tag, if one exists. This means the container is available for use in tests (like the sync-from-genesis test) in under 10 minutes, but still guarantees that any container pulled by branch or tag contains working software.
Tested
Some example builds:
eos:develop
eos:release/2.0.x
eos:release/1.8.x
eos:develop
eos:release/2.0.x
eos:release/1.8.x
See Also
This pull request is part of a set:
eos:develop
eos:release/2.0.x
eos:release/1.8.x
Consensus Changes
None.
API Changes
None.
Documentation Additions
None.