This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix for notice forwarding #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1516,6 +1516,7 @@ namespace eosio { | |||
| // notices of previously unknown blocks or txns, | |||
| // | |||
| fc_dlog(logger, "got a notice_message from ${p}", ("p",c->peer_name())); | |||
| bool can_fwd = false; | |||
There was a problem hiding this comment.
can we get a comment here or below, indicating we are not currently setting it?
There was a problem hiding this comment.
It's going to take a little more time to figure out the safe way to determine whether or not to forward notifications.
brianjohnson5972
approved these changes
Nov 30, 2017
spoonincode
pushed a commit
that referenced
this pull request
Dec 8, 2017
fix for notice forwarding (reapplied on noon branch)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, this should prevent notice forwarding all together. Which is OK for now since the mesh connects all producers to each other.