Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Net plugin sync - develop #8276

Merged
merged 25 commits into from
Dec 3, 2019
Merged

Net plugin sync - develop #8276

merged 25 commits into from
Dec 3, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Dec 3, 2019

Change Description

  • Fix issue with getting in infinite loop while processing handshake
  • Guard against overflow of handshake generation count
  • Fix problem with self connection logic
  • Better handling of sync/head-catchup transition.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

heifner added 25 commits December 3, 2019 08:26
@heifner
Rename sync_state struct to peer_sync_state to distinguish from sync_…
9ecfede 
…state enum
@heifner
Fix self check to compare to this node's node_id
bc45ace
@heifner
Remove dead code
473e03c
@heifner
Avoid wrapping generation
b293d28
@heifner
sync_recv_block should only be called if in lib catchup
986759f
@heifner
Add full version to startup ilog message if diff than version
3d5c904
@heifner
Add additional logging
294fe24
@heifner
Don't send handshakes to everyone as often as it just causes confusio…
c33f4fd 
…n. Also don't go into syncing mode for head catchup.
@heifner
Only send handshake if it has changed from last send. Log all incomin…
275d19d 
…g blocks.
@heifner
If block less than lib received outside of lib catchup then tell peer…
08e24ac 
… to stop sending
@heifner
Make sure handshake is first response to first handshake from peer. A…
33de554 
…dd extra verification in blk_send_branch that we have valid handshake from peer.
@heifner
Send head id along with verify request_message so if not on a fork th…
3f87842 
…e peer can send from head instead of from lib
@heifner
If verifying catchup and num is notice is less than lib, nothing to do.
45bd185
@heifner
Reduce received block and bcast block logging to debug level
faff819
@heifner
Add const and extra logging
2bb9fbd
@heifner
Additional logging for when block is not applied to head
40096e6
@heifner
If peer sending less than lib and we have notified it of our lib, the…
0a3937e 
…n close connection
@heifner
Only log block not applied to head if not running in irreversible mode
c766e48
@heifner
Explicitly guard agaisnt null block_state->block
ad571a9
@heifner
Only cancel wait if not syncing
20432cd
@heifner
send handshake if head_id changed
88b13c6
@heifner
Fix compile error
2528433
@heifner
Always cancel_wait on receive
d810fcd
@heifner
on fork should be true if not found
6621879
@heifner
Do not send a go away message if unable to fetch a block as we might …
f791cc1 
…have just switched to a diff fork
@heifner heifner merged commit 2993b1c into develop Dec 3, 2019
@heifner heifner deleted the net-plugin-sync-dev branch December 3, 2019 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brianjohnson5972 brianjohnson5972 brianjohnson5972 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @brianjohnson5972