This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[Develop] explictly use openssl 1.1 via brew on macos #8245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
At the moment our macos binaries are not working for fresh mac installs, see #8235.
homebrew has removed openssl 1.0 from their repositories. See some discussion here
Homebrew/homebrew-core#46876
Additionally, they decided to alias
openssl
to install and point to the 1.1 version, see discussion hereHomebrew/homebrew-core#47034
The last bit is somewhat interesting: if on a fresh macos you do a
brew install openssl
you'll end up installing openssl 1.1 and also/usr/local/opt/openssl
is symlinked over to[email protected]
. So to fix our binary problem all we need to do is reset our CI image and let it install openssl 1.1 now instead.However, that won't (easily) cause builds on macos installations that already have openssl 1.0 installed to use 1.1 as
/usr/local/opt/openssl
could still be pointing to openssl 1.0. At least for me, just doing abrew upgrade
won't fix up this directory to be 1.1, andbrew upgrade openssl
won't do anything since openssl 1.1 is already installed. One does wonder if another openssl 1.1 upgrade is pushed out in homebrew if the upgrade will stomp on 1.0 or not?Anyways, that long winded train of thought is there just to lead in to the simple solution: let's just be more explicit and ask for 1.1 directly. It ensures everyone using the build scripts will indeed be using it and we won't get odd surprises.
Consensus Changes
API Changes
Documentation Additions