Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[Develop] explictly use openssl 1.1 via brew on macos #8245

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

spoonincode
Copy link
Contributor

@spoonincode spoonincode commented Nov 25, 2019

Change Description

At the moment our macos binaries are not working for fresh mac installs, see #8235.

homebrew has removed openssl 1.0 from their repositories. See some discussion here
Homebrew/homebrew-core#46876
Additionally, they decided to alias openssl to install and point to the 1.1 version, see discussion here
Homebrew/homebrew-core#47034

The last bit is somewhat interesting: if on a fresh macos you do a brew install openssl you'll end up installing openssl 1.1 and also /usr/local/opt/openssl is symlinked over to [email protected]. So to fix our binary problem all we need to do is reset our CI image and let it install openssl 1.1 now instead.

However, that won't (easily) cause builds on macos installations that already have openssl 1.0 installed to use 1.1 as /usr/local/opt/openssl could still be pointing to openssl 1.0. At least for me, just doing a brew upgrade won't fix up this directory to be 1.1, and brew upgrade openssl won't do anything since openssl 1.1 is already installed. One does wonder if another openssl 1.1 upgrade is pushed out in homebrew if the upgrade will stomp on 1.0 or not?

Anyways, that long winded train of thought is there just to lead in to the simple solution: let's just be more explicit and ask for 1.1 directly. It ensures everyone using the build scripts will indeed be using it and we won't get odd surprises.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@NorseGaud
Copy link
Contributor

NorseGaud commented Dec 2, 2019

1.8.x is covered in #8246
2.0.x in #8247

@NorseGaud NorseGaud changed the title explictly use openssl 1.1 via brew on macos [Develop] explictly use openssl 1.1 via brew on macos Dec 2, 2019
@NorseGaud NorseGaud merged commit 85010e0 into develop Dec 2, 2019
@NorseGaud NorseGaud deleted the brew_openssl_11 branch December 2, 2019 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants