This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kj4ezj
suggested changes
Aug 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have two separate scripts that do the same thing?
I think we can make this all one script.
NorseGaud
approved these changes
Aug 21, 2019
jerstern
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎡
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
We mistakenly forgot that the new pipelines call scripts which then call docker with various commands to do things such as execute builds and tests. This resulted in all Linux distros packing incorrect build artifacts which were uploaded to Buildkite as seen on the artifacts tab here: https://buildkite.com/EOSIO/eosio-beta/builds/1269#83444e21-7dbe-4df9-8437-6157af542d38
package.sh
script that runs on the build host..cicd/package-builder.sh
to.cicd/package.sh
..cicd/pipeline.yml
to use this script on Package Builder steps..cicd/package-builder.sh
.package.sh
.Consensus Changes
API Changes
Documentation Additions