Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Trav poc wrong artifacts #7780

Merged
merged 9 commits into from
Aug 21, 2019
Merged

Trav poc wrong artifacts #7780

merged 9 commits into from
Aug 21, 2019

Conversation

scottarnette
Copy link
Contributor

@scottarnette scottarnette commented Aug 20, 2019

Change Description

We mistakenly forgot that the new pipelines call scripts which then call docker with various commands to do things such as execute builds and tests. This resulted in all Linux distros packing incorrect build artifacts which were uploaded to Buildkite as seen on the artifacts tab here: https://buildkite.com/EOSIO/eosio-beta/builds/1269#83444e21-7dbe-4df9-8437-6157af542d38

  • Created new package.sh script that runs on the build host.
  • Moved artifact upload steps from .cicd/package-builder.sh to .cicd/package.sh.
  • Updated .cicd/pipeline.yml to use this script on Package Builder steps.
  • Removed .cicd/package-builder.sh.
  • Travis is not affected by this change.
  • Mac also calls package.sh.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@scottarnette
Copy link
Contributor Author

scottarnette commented Aug 21, 2019

@scottarnette scottarnette marked this pull request as ready for review August 21, 2019 14:02
Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have two separate scripts that do the same thing?
I think we can make this all one script.

Copy link
Contributor

@jerstern jerstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎡

@scottarnette scottarnette merged commit 2a1510e into trav-poc Aug 21, 2019
@scottarnette scottarnette deleted the trav-poc-wrong-artifacts branch August 21, 2019 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants