Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Make the submodule regression check more robust #7068

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Make the submodule regression check more robust #7068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/submodule_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ for k in "${!BASE_MAP[@]}"; do
echo " timestamp on $BUILDKITE_BRANCH: $pr_ts"
echo " timestamp on $BUILDKITE_PULL_REQUEST_BASE_BRANCH: $base_ts"
if (( $pr_ts < $base_ts)); then
echo "ERROR: $k is older on $BUILDKITE_BRANCH than $BUILDKITE_PULL_REQUEST_BASE_BRANCH"
exit 1
echo "$k is older on $BUILDKITE_BRANCH than $BUILDKITE_PULL_REQUEST_BASE_BRANCH; investigating..."

if for c in `git log $BUILDKITE_BRANCH ^$BUILDKITE_PULL_REQUEST_BASE_BRANCH --pretty=format:"%H"`; do git show --pretty="" --name-only $c; done | grep -q "^$k$"; then
echo "ERROR: $k has regressed"
exit 1
else
echo "$k was not in the diff; no regression detected"
fi
fi
done