Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Monitor wallet lock file and shut down if it's removed. #6691

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

jgiszczak
Copy link
Contributor

Change Description

Monitor wallet lock file and shut down keosd if it's removed. Resolves #5998.

Consensus Changes

N/A

API Changes

N/A

Documentation Additions

N/A

@jgiszczak jgiszczak requested a review from spoonincode February 2, 2019 00:14
@spoonincode
Copy link
Contributor

Polling is pretty lousy but I realize there is no quick way to integrate inotify/kevent/whatever-win32-uses

@jgiszczak
Copy link
Contributor Author

I did try inotify first and unfortunately it's completely unreliable. On Ubuntu with encrypted home directories, encryptfs completely mangles inotify events, to the point of unuseability. Most events are entirely lost. Except when they're not. Then they are again. With both false positives and false negatives rampant, I gave up on it entirely.

Convert unrelated FC_THROW to EOS_THROW and correct English in error
text.
@spoonincode spoonincode merged commit 28e6c95 into develop Feb 4, 2019
@jgiszczak jgiszczak deleted the monitor-wallet-lock branch February 4, 2019 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants