This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Priority queue #6577
Merged
Priority queue #6577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjohnson5972
approved these changes
Jan 11, 2019
wanderingbort
suggested changes
Jan 11, 2019
plugins/net_plugin/net_plugin.cpp
Outdated
| } | ||
|
|
||
| void net_plugin_impl::start_txn_timer() { | ||
| transaction_check->expires_from_now( txn_exp_period); | ||
| transaction_check->async_wait( [this](boost::system::error_code ec) { | ||
| transaction_check->async_wait(app().get_priority_queue().wrap(priority::low-1, [this](boost::system::error_code ec) { |
There was a problem hiding this comment.
I don't really like the mixed metaphor of priority is a category and priority is a number. I'm fine with having named points on the range, but then perhaps we can name this one as well (even if only locally).
I guess, in a single logical bit of code it should consistently treat priority as a category or a number but not both?
I have some comments on the appbase changes too that regard this duality
There was a problem hiding this comment.
Used a variable to name it locally. appbase was updated to just always execute the highest so there are no more ranges only named points on the range.
wanderingbort
approved these changes
Jan 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
applicationthreadAll posted jobs now require a priority that determines the order of execution. If any jobs are posted to the main application thread without using the provided priority wrapper they are executed as if they have the highest priority. Therefore, the priority wrapper should be used for all jobs posted either via
post,async_read,async_write,async_wait, etc.Consensus Changes
None
API Changes
Any plugins posting to the main
applicationthread should consider using the new priority wrapper.Documentation Additions
See API changes.