This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Final keosd unix socket changes #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify cleos to handle auto launch of keosd via unix socket. cleos will now only auto launch if the wallet_url is the default path for the unix socket. Additionally, auto launched keosd will explicitly have its http & https tcp ports disabled.
|
FWIW, I did verify that the "docker quick start instructions" still work. Those instructions launch keosd with --http-server-address so not really affected by change at all. |
jgiszczak
approved these changes
Sep 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of the 3 final keosd unix socket changes.