This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Launcher tests #5476
Merged
Launcher tests #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programs/eosio-launcher/main.cpp
Outdated
|
|
||
| if(!c.running()) { | ||
| cerr << "child not running after spawn " << cmd << endl; | ||
| for (int i = 0; i > 0; i++) { |
There was a problem hiding this comment.
We really want this tight loop, with no delay, running till i rolls over to negative?
There was a problem hiding this comment.
A lot of this code is copy-pasted from elsewhere in the launcher. I will simplify it and pull it out into a function.
programs/eosio-launcher/main.cpp
Outdated
| bp::env["EOSIO_HOME"] = host.eosio_home, | ||
| bp::env["EOSIO_NODE"] = node_num ); | ||
|
|
||
| if(!c.running()) { |
There was a problem hiding this comment.
Can we make the following lines a method to use here and below?
| @@ -33,8 +35,8 @@ rm $datadir/stderr.txt | |||
| ln -s $log $datadir/stderr.txt | |||
|
|
|||
| relaunch() { | |||
| echo "$rundir/$prog $* --data-dir $datadir --config-dir etc/eosio/node_$EOSIO_NODE > $datadir/stdout.txt 2>> $datadir/$log " | |||
| nohup $rundir/$prog $* --data-dir $datadir --config-dir etc/eosio/node_$EOSIO_NODE > $datadir/stdout.txt 2>> $datadir/$log & | |||
| echo "$rundir/$prog $qargs $* --data-dir $datadir --config-dir etc/eosio/node_$EOSIO_NODE > $datadir/stdout.txt 2>> $datadir/$log " | |||
There was a problem hiding this comment.
Does this not run into the same issues with the * exploding to all the files in the current directory?
There was a problem hiding this comment.
No because I have added quotes around the * argument. This is not a very general solution but works for --filter-on *.
brianjohnson5972
approved these changes
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add use of the launcher-generated bios_boot.sh as the default for existing tests
Minor modifications to some tests to work with bios_boot.sh (usually buying more RAM)
Modify some tests to use the existing bootstrap method (they require partial bootstrapping)
Add a new launcher test that tests launcher options such as --bounce and --down