This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
process generated transactions #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytemaster
reviewed
Aug 25, 2017
| template<> | ||
| void check_output(const types::Message& expected, const types::Message& actual) { | ||
| try { | ||
| check_output(expected.code, actual.code); |
There was a problem hiding this comment.
why don't you move the try{ } catch{} . into check_output and pass the "in .x" as a const char* 3rd argument? I think it would make the code more readable.
bytemaster
reviewed
Aug 25, 2017
| /** | ||
| * clear all common data | ||
| */ | ||
| inline |
There was a problem hiding this comment.
put inline on same line as return statement.
bytemaster
reviewed
Aug 25, 2017
| types::transfer{sender, recipient, amount}); | ||
| auto info = get_info(); | ||
| trx.expiration = info.head_block_time + 100; //chain.head_block_time() + 100; | ||
| trx.set_reference_block(info.head_block_id); | ||
| transaction_helpers::set_reference_block(trx, info.head_block_id); |
There was a problem hiding this comment.
I find the name transaction_helpers long, I feel we should say "using transaction_helpers" unless there is clear possibility of name conflict.
bytemaster
reviewed
Aug 25, 2017
| @@ -1116,9 +1117,9 @@ R"( | |||
| trx.messages.resize(1); | |||
| trx.messages[0].code = config::EosContractName; | |||
| trx.messages[0].authorization.emplace_back(types::AccountPermission{"simplecoin","active"}); | |||
| trx.setMessage(0, "setcode", handler); | |||
| transaction_helpers::set_message(trx, 0, "setcode", handler); | |||
There was a problem hiding this comment.
perhaps renaming the methods . transaction_set_message rather than transaction_helpers::set_message if we are going to be verbose everywhere. If follows the naming convention one would use for a object-oriented C api.
bytemaster
approved these changes
Aug 25, 2017
This was referenced Aug 25, 2017
heipacker
pushed a commit
to TP-Lab/eos
that referenced
this pull request
Jan 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #174
test cases will be easier to write and more meaningful once there is contract support for sync and async transactions. However I wanted to go ahead and review what was working without impacting the existing code/tests.