This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Use node_id for duplicate connection resolution 📦 #10786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
changed the title
plugins/net_plugin/net_plugin.cpp
Outdated
| } else if (my_impl->p2p_address < msg.p2p_address) { | ||
| } else if (my_impl->node_id < msg.node_id) { | ||
| fc_dlog( logger, "not duplicate, my_impl->node_id '${lhs}' < msg.node_id '${rhs}'", | ||
| ("lhs", my_impl->node_id)("rhs", msg.node_id) ); | ||
| // only the connection from lower p2p_address to higher p2p_address will be considered as a duplicate, |
There was a problem hiding this comment.
The references to p2p2_address in comment should be changed as well.
huangminghuang
approved these changes
Oct 6, 2021
huangminghuang
approved these changes
Oct 6, 2021
12 tasks
…-connection-dev-boxed
This was referenced Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
node_idinstead ofp2p_address.net_versiondup_node_id_goawaycreated for this PR.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions