This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Always attempt to resync when receiving a block less than LIB. #10434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Continue testing for today and Kevin can review as soon as he is back. |
heifner
reviewed
Jun 24, 2021
heifner
suggested changes
Jun 24, 2021
plugins/net_plugin/net_plugin.cpp
Outdated
| @@ -3971,6 +3981,7 @@ namespace eosio { | |||
| " _port \tremote port number of peer\n\n" | |||
| " _lip \tlocal IP address connected to peer\n\n" | |||
| " _lport \tlocal port number connected to peer\n\n") | |||
| ( "p2p-always-resync", bpo::value<bool>()->default_value(false), "Always attempt to resync even when peer sends blocks earlier than this node's last irreversible block") | |||
There was a problem hiding this comment.
I think we should not add this new option and just make this the behavior.
There was a problem hiding this comment.
PR name/description needs to be updated.
jgiszczak
changed the title
heifner
approved these changes
Jun 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Option to allow nodeos to continue syncing with a peer that has sent blocks older than LIB due to latency.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions