Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Correct fix-irreversible-blocks option default value which was set in… #10262

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

linhuang-blockone
Copy link
Contributor

…correctly

Change Description

https://blockone.atlassian.net/browse/EPE-922

Default value of fix-irreversible-blocks was set by
("fix-irreversible-blocks", bpo::value<bool>()->default_value("false"). The "false" makes it as a string and unintentionally causes the default value to be true. This in turn causes failure of reconstructing blocks.index in block_log_impl of block_log.cpp as it requires correct value of fix_irreversible_blocks.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Manual testing

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@linhuang-blockone linhuang-blockone merged commit 8a42c74 into develop Apr 19, 2021
@linhuang-blockone linhuang-blockone deleted the fix_irr_blocks_default_val_fix branch April 19, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants