This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Correct fix-irreversible-blocks option default value which was set in… #10262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…correctly
Change Description
https://blockone.atlassian.net/browse/EPE-922
Default value of
fix-irreversible-blocks
was set by("fix-irreversible-blocks", bpo::value<bool>()->default_value("false")
. The"false"
makes it as a string and unintentionally causes the default value to betrue
. This in turn causes failure of reconstructing blocks.index inblock_log_impl
ofblock_log.cpp
as it requires correct value offix_irreversible_blocks
.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Manual testing
Consensus Changes
API Changes
Documentation Additions