This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Rel.2.1.x: Exit nodeos if fork_db is corrupted and lib cannot advance #10170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Mar 22, 2021
heifner
suggested changes
Mar 23, 2021
| @@ -428,6 +428,9 @@ class producer_plugin_impl : public std::enable_shared_from_this<producer_plugin | |||
| chain_plugin::handle_bad_alloc(); | |||
| } catch ( boost::interprocess::bad_alloc& ) { | |||
| chain_plugin::handle_db_exhaustion(); | |||
| } catch ( const fork_database_exception& ) { | |||
| wlog("Cannot recover from fork_db exception. Shutting down."); | |||
There was a problem hiding this comment.
elog. Log the exception details. Add to the exception message the details you had in the log message.
There was a problem hiding this comment.
Agreed. Done.
There was a problem hiding this comment.
Add to the EOS_ASSERT the details you had in the log message.
heifner
approved these changes
Mar 23, 2021
linhuang-blockone
changed the title
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
https://blockone.atlassian.net/browse/EPE-831
#10140 reports that nodeos gets stuck after restart due to a corrupt forkdb. When this happens, log_irreversible keeps throwing the same exception whenever it executes. The solution is to exit nodeos. Log detailed information to help future debugging.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions