Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

revert changes to empty string as present for lower_bound, upper_bound, or index_value #10019

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

huangminghuang
Copy link
Contributor

@huangminghuang huangminghuang commented Feb 8, 2021

Change Description

The PR

  • reverts the change in PR 9964 which treat empty string as present for lower_bound, upper_bound and index_value in kv table query
  • removes the bytes default for get_kv_table_rows_params.encode_type

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

The encode_type field of get_kv_table_rows is not defaulted to "bytes" any longer and is defaulted based off of the abi type for the "index_param". It is defaulted to "name" for a name type, "string" for string type, and "dec" for integer types.

Documentation Additions

  • Documentation Additions

@huangminghuang huangminghuang force-pushed the huangminghuang/fix-kv-table-query branch from 7e97b49 to f641b09 Compare February 10, 2021 19:28
@huangminghuang huangminghuang merged commit b1e1ffa into develop Feb 11, 2021
@huangminghuang huangminghuang deleted the huangminghuang/fix-kv-table-query branch February 19, 2021 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants