This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
EPE-165: Improve logic for unlinkable blocks while sync'ing #10012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic for handling unlinkable blocks while sync'ing closes the node prematurely when the node is flooded with unlinkable blocks in a short time window. This fix groups unlinkable blocks into time windows in order to manage the flooding condition.
heifner
suggested changes
Feb 5, 2021
1) changed rejected block tracking to per connection 2) block_status-monitor updated with max rejected windows
heifner
suggested changes
Feb 6, 2021
1) corrected initialization of window size 2) simplified rejected() logic based on feedback 3) simplified state tracking
1) changed ctor to explicit 2) corrected ctor default window_size
1) Moved mutex as sugested
heifner
approved these changes
Feb 9, 2021
|
Approved, but please don't merge until LRT has been run on this change. All net_plugin changes should have LRTs run before merge. |
Remove "if" check from accepted() logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for handling unlinkable blocks while sync'ing closes
the node prematurely when the node is flooded with unlinkable blocks in
a short time window. This fix groups unlinkable blocks into time windows
in order to manage the flooding condition.
Change Description
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions