Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

nodeos not returning code of '2' when database is dirty #7658

Closed
spoonincode opened this issue Jul 16, 2019 · 1 comment
Closed

nodeos not returning code of '2' when database is dirty #7658

spoonincode opened this issue Jul 16, 2019 · 1 comment
Assignees
@ndcgundlach @johndebord
Labels
bug

Comments

@spoonincode
Copy link
Contributor

There is code in nodeos that intends to have nodeos exit with a code of 2 when the database is dirty. It does this by looking at the text in the exception that would typically be fired from chainbase, specifically pinnable_mapped_file

However, appbase swallows exceptions from plugin init and simply returns false from initialize<>() causing nodeos to exit with a -1 instead.

This is almost certainly a regression from some point in time; though it's not immediately clear to me if it's worth fixing this behavior or not?
@johndebord johndebord self-assigned this Jul 22, 2019
@spoonincode spoonincode mentioned this issue Aug 10, 2019
Merged
3 tasks
@ndcgundlach ndcgundlach self-assigned this Sep 25, 2019
brianjohnson5972 added a commit that referenced this issue Dec 16, 2019
@brianjohnson5972
Merge pull request #8046 from EOSIO/issue_7658
e803c36 
#7658: modified code to handle new db_runtime_exception
@ndcgundlach
Copy link
Contributor

Fixed and merged into develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ndcgundlach ndcgundlach

@johndebord johndebord

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ndcgundlach @spoonincode @johndebord