Fix test error: set allow_dirty to true for db2 to make test pass

[b1aafulei]

Previously, in test/test.cpp of the branch v2.0.x, it was

chainbase::database db(temp, database::read_write, 1024*1024*8);
chainbase::database db2(temp); /// open an already created db

The test would always fail, complaining that database dirty flag set.

Now the above code is changed into

chainbase::database db(temp, database::read_write, 1024*1024*8);
chainbase::database db2(temp, database::read_only, 0, true); /// open an already created db

so that it becomes okay for db2 to start off from a dirty database opened by db, and thus the test would pass.

Note that the branch v2.0.x is currently tracked by both the master and release/2.0.x branches of EOSIO/eos. It would be desired if we can make the test pass.

[heifner]

Why are these tests not run as part of eosio?

[b1aafulei]

Hi Kevin. Thanks for the question!

The current automated tests in the EOSIO/eos repository are driven by ctest and run by buildkite. This chainbase_test was not added in the CMakeLists as a ctest test, and thus is not run automatically as part of eosio.

It should be however. I have made some changes to the CMakeLists in this pull request. Now the chainbase_test will be included in the ctest. Care has been taken so that it will work properly, either when EOSIO/chainbase is a standalone library, or when EOSIO/chainbase is a submodule for the EOSIO/eos repository.

Of course, this fix targets only the EOSIO/chainbase:v2.0.x branch, and should affect the EOSIO/eos:release/2.0.x and EOSIO/eos:master branches.

[revl]

LGTM