Update Dockerfile #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferag
requested review from
orviz,
davrodgon,
mariojmdavid and
samuelbernardolip
as code owners
davrodgon
reviewed
Apr 26, 2022
There was a problem hiding this comment.
It seems reasonable to move from depending of an image hosted under a personal account in Docker Hub to explicitly having all in the Dockerfile here.
Just wondering if after setting up WORKDIR it is necesasry using "/FAIR_eva" in the following lines.
Also there are a couple of lines that look like their main use is for debugging (ls, cat start.sh).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.