removed null values from profile #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hrishikesh Agarwal <[email protected]>
kaybhutani
reviewed
Feb 8, 2022
src/components/UserProfile.jsx
Outdated
| @@ -109,7 +109,11 @@ export const UserDetails = ({ | |||
| placeholder='Your name' | |||
| > | |||
| <h2 className='user-profile-name'> | |||
| {user.Name ? user.Name : user.username} | |||
| {user.Name | |||
| ? user.Name === 'null' | |||
There was a problem hiding this comment.
why do we have null as string? @SundeepChand do you have any idea?
There was a problem hiding this comment.
also, looks like this == 'null' comparison is being used in multiple places, let's make a function for it and use it everywhere
Signed-off-by: Hrishikesh Agarwal <[email protected]>
kaybhutani
reviewed
Feb 14, 2022
| @@ -92,6 +92,10 @@ export const UserDetails = ({ | |||
| allowEditing, | |||
| updateProfile | |||
| }) => { | |||
| const checkNull = (value) => { | |||
There was a problem hiding this comment.
@codetheorem i think you were earlier checking for ? user.Name === 'null'
if the values are null and not string 'null' we dont need a separate function.
Signed-off-by: Hrishikesh Agarwal <[email protected]>
kaybhutani
approved these changes
Feb 18, 2022
|
@codetheorem there are some conflicts. can you rebase once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hrishikesh Agarwal [email protected]
Issue Number
fixes #99
Describe the changes you've made
I have edited the userprofile component to remove the null values from profile.
Describe if there is any unusual behavior (Any Warning) of your code(Write
NAif there isn't)NA
http://localhost:3000/profile/5fb67859b20c0c001799eac2 you can visit this url.
Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route