Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a module for converting to/from dicts #126

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Added a module for converting to/from dicts #126

merged 7 commits into from
Aug 28, 2023

Conversation

jesper-friis
Copy link
Contributor

Description:

Added a module for converting to/from dicts

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Copy link

@Treesarj Treesarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but build is failing(pls fix)

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.32% 🎉

Comparison is base (a71409f) 74.78% compared to head (a56709a) 76.11%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   74.78%   76.11%   +1.32%     
==========================================
  Files          15       17       +2     
  Lines        1285     1348      +63     
==========================================
+ Hits          961     1026      +65     
+ Misses        324      322       -2     
Files Changed Coverage Δ
tripper/__init__.py 100.00% <ø> (ø)
tripper/mappings/mappings.py 67.39% <ø> (ø)
tripper/triplestore.py 82.51% <ø> (+0.61%) ⬆️
tripper/tripper.py 88.13% <ø> (-0.20%) ⬇️
tripper/convert/__init__.py 100.00% <100.00%> (ø)
tripper/convert/convert.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might fix the docs build issue?

tripper/convert/convert.py Show resolved Hide resolved
@jesper-friis jesper-friis merged commit 3b3c231 into master Aug 28, 2023
9 checks passed
@jesper-friis jesper-friis deleted the fromdict branch August 28, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants