Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide widget replacement toggle #3010

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

ghostwords
Copy link
Member

The first part of #3007. We could make the deprecation more visible by doing something like #2783, but it doesn't feel like we need to in this case.

@ghostwords ghostwords added the widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets label Aug 13, 2024
@lenacohen lenacohen self-requested a review August 14, 2024 14:21
Copy link
Contributor

@lenacohen lenacohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is more of a comment on this issue than this PR, but I think that if we're making the Widget Exceptions work as expected, we should include shortcut for people to allow all widgets globally. This could be a button that adds all widgets to the exceptions field, or another checkbox.

@ghostwords
Copy link
Member Author

Thanks! Why would we want to make it easy to inadvertently lower your privacy across the board?

@ghostwords ghostwords merged commit f6cff48 into master Aug 14, 2024
2 checks passed
@ghostwords ghostwords deleted the hide-widget-replacement-toggle branch August 14, 2024 15:25
@lenacohen
Copy link
Contributor

Thanks! Why would we want to make it easy to inadvertently lower your privacy across the board?

We'd definitely want to include text warning that "Allowing all widgets will enable tracking by..." If people are using the "Enable widget replacement" toggle, I imagine that means there are people who don't want to click to show widgets on every site. But I think it's okay if we just allow users to enable widgets selectively, then people who don't like the feature can manually select every widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants