Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Re-activate and Update Yahoo_Japan.xml #9955

Merged
merged 2 commits into from
Jul 6, 2017
Merged

Re-activate and Update Yahoo_Japan.xml #9955

merged 2 commits into from
Jul 6, 2017

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented May 18, 2017

This is ready for review now. thanks.

@jeremyn
Copy link
Contributor

jeremyn commented May 19, 2017

You can run tests locally by the way, you don't need to rely on Travis, if that's why you made a "work-in-progress" pull request.

@cschanaj
Copy link
Collaborator Author

cschanaj commented May 19, 2017

@jeremyn Thank you for your advice. I had found that lots of comment are outdated and I would like to update them. I wanted to passed them to my bot but it require manual editing and sorting to fit the input format. In particular, I would like a make a script to sort the sub-domains from the comment to the desired order automatically. It was late at night so I made it work-in-progress.

Sorry for the inconvenience incurred.

@jeremyn
Copy link
Contributor

jeremyn commented May 19, 2017

Another FYI, the Sublist3r application that we recommend in the contributing guidelines sorts the domains the way we like (HTTPS Everywhere contributors have also contributed to Sublist3r). You may want to use that instead of your custom stuff, for instance here.

@cschanaj
Copy link
Collaborator Author

cschanaj commented May 19, 2017

I usually use Sublist3r as recommended when the number of sub-domains is small. However, for some organizational domain like universities, the output list is simply overwhelming even with automated ruleset generation tools available (and many sub-domains have unknown usage). For example, I remember that I got more than 2k sub-domains using Sublist3r when I was creating a ruleset for www.ust.hk, it is difficult to decide which sub-domains should be included in a ruleset.

As for this time, yahoo.co.jp has 1.66k sub-domains. I really do not want to go through the Sublist3r output. Therefore I manually constructed the yahoo-japan-sub-domains.txt from the comment and crawled some sub-domains from the homepage as the source. AFAIK Sublist3r doesn't support sorting input from external source, so I made my own one (for personal use only).

Anyway, thanks!!

P.S Removed the pointer to my repo to avoid confusing future readers.

@cschanaj cschanaj closed this Jun 22, 2017
@cschanaj cschanaj reopened this Jun 22, 2017
@cschanaj
Copy link
Collaborator Author

cschanaj commented Jun 22, 2017

#10545 Fixed

P.S. It looks like that I have resolved the merge conflict wrongly. I am going to fix this tonight.

@cschanaj cschanaj mentioned this pull request Jun 22, 2017
20 tasks
@cschanaj cschanaj changed the title Update Yahoo_Japan.xml Re-activate and Update Yahoo_Japan.xml Jun 22, 2017
@cschanaj cschanaj mentioned this pull request Jun 27, 2017
@ghost
Copy link

ghost commented Jul 1, 2017

@J0WI ping

@J0WI
Copy link
Contributor

J0WI commented Jul 2, 2017

Pong.
I think @jeremyn is doing the review here, so let's just wait for his answer.

@jeremyn
Copy link
Contributor

jeremyn commented Jul 2, 2017

I'm not particularly involved here.

(EDIT: As a general rule, I assign a pull request to myself if I want to own it.)

<target host="gyao.yahoo.co.jp" />

<target host="headlines.yahoo.co.jp" />
<target host="hr.yahoo.co.jp" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id.yahoo.co.jp

<target host="chiebukuro.yahoo.co.jp" />
<target host="detail.chiebukuro.yahoo.co.jp" />
<!-- 404
target host="odhistory.shopping.yahoo.co.jp" /-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this documented.

<target host="biz-form.ec.yahoo.co.jp" />
<!--target host="help.yahoo.co.jp" /-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this host documented

@cschanaj
Copy link
Collaborator Author

cschanaj commented Jul 5, 2017

@J0WI thanks!!

@J0WI J0WI merged commit 60a02bf into EFForg:master Jul 6, 2017
@cschanaj cschanaj deleted the cschanaj-yahoo.co.jp branch July 6, 2017 15:13
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
* Re-activate and Update Yahoo_Japan.xml

* Update Yahoo_Japan.xml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants