-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Re-activate and Update Yahoo_Japan.xml #9955
Conversation
You can run tests locally by the way, you don't need to rely on Travis, if that's why you made a "work-in-progress" pull request. |
@jeremyn Thank you for your advice. I had found that lots of comment are outdated and I would like to update them. I wanted to passed them to my bot but it require manual editing and sorting to fit the input format. In particular, I would like a make a script to sort the sub-domains from the comment to the desired order automatically. It was late at night so I made it work-in-progress. Sorry for the inconvenience incurred. |
Another FYI, the Sublist3r application that we recommend in the contributing guidelines sorts the domains the way we like (HTTPS Everywhere contributors have also contributed to Sublist3r). You may want to use that instead of your custom stuff, for instance here. |
I usually use As for this time, Anyway, thanks!! P.S Removed the pointer to my repo to avoid confusing future readers. |
#10545 Fixed
|
@J0WI ping |
Pong. |
I'm not particularly involved here. (EDIT: As a general rule, I assign a pull request to myself if I want to own it.) |
<target host="gyao.yahoo.co.jp" /> | ||
|
||
<target host="headlines.yahoo.co.jp" /> | ||
<target host="hr.yahoo.co.jp" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id.yahoo.co.jp
<target host="chiebukuro.yahoo.co.jp" /> | ||
<target host="detail.chiebukuro.yahoo.co.jp" /> | ||
<!-- 404 | ||
target host="odhistory.shopping.yahoo.co.jp" /--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this documented.
<target host="biz-form.ec.yahoo.co.jp" /> | ||
<!--target host="help.yahoo.co.jp" /--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this host documented
@J0WI thanks!! |
* Re-activate and Update Yahoo_Japan.xml * Update Yahoo_Japan.xml
This is ready for review now. thanks.