Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Re-activate and Update Alltop.com.xml #9862

Merged
merged 1 commit into from
May 19, 2017
Merged

Re-activate and Update Alltop.com.xml #9862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/chrome/content/rules/Alltop.com.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!--
Remark: *.alltop.com has a wildcard DNS record and
a wildcard certificate.
-->
<ruleset name="AllTop.com">
<target host="alltop.com" />
<target host="*.alltop.com" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there also a reason to use a wildcard target or can we list all hosts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard DNS basically redirect https://foo.alltop.com to http://alltop.com/?keywords=foo. And there is 700+ sub-domain support HTTPS correctly. I do not want this to overwhelm reviewers and future maintainers. If you prefer, I can rebase it.

See https://gist.github.com/cschanaj/f0fdfa8f0535ded83603b1dfe1827b4e (Only checked automatically).

<test url="http://advertising.alltop.com/" />
<test url="http://anime.alltop.com/" />
<test url="http://answers.alltop.com/" />
<test url="http://bitcoin.alltop.com/" />
<test url="http://www.alltop.com/" />

<securecookie host=".+" name=".+" />

<rule from="^http:" to="https:" />
</ruleset>
15 changes: 0 additions & 15 deletions src/chrome/content/rules/Alltop.xml
View file
Open in desktop

This file was deleted.