Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Update Vcommerce.com.xml #17924

Merged
merged 3 commits into from
May 9, 2019
Merged

Update Vcommerce.com.xml #17924

merged 3 commits into from
May 9, 2019

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented May 8, 2019

@cschanaj cschanaj added the amazon-s3-2020 Bare s3.amazonaws.com domain deprecation, see #17912 label May 8, 2019
@cschanaj
Copy link
Collaborator Author

cschanaj commented May 8, 2019

@pipboy96 please refrain from modify my PR and review before the Travis complete ...

@pipboy96
Copy link
Contributor

pipboy96 commented May 8, 2019

@cschanaj You can remove any commit using git reset --hard. Also, this change was only cosmetic. I am currently scanning for more subdomains using Amass.

@cschanaj
Copy link
Collaborator Author

cschanaj commented May 8, 2019

@pipboy96 That will require a force-push and thus complicates the PR. I will preserve the change this time but please avoid editing my PR.

@pipboy96
Copy link
Contributor

pipboy96 commented May 8, 2019 •
edited
Loading

I apologize for editing. Can you not include needless \n's in xml in future?

@pipboy96

This comment has been minimized.

Sign in to view
@pipboy96
Copy link
Contributor

pipboy96 commented May 8, 2019

More subdomains:

vcommerce.com
mhcpoe.vcomshop.com.staging.vcommerce.com
services.staging.vcommerce.com
staging.vcommerce.com
uw2a-net01.vcommerce.com
confluence.vcommerce.com
services.vcommerce.com
uw2b-net02.vcommerce.com
ontrack.vcommerce.com
b2bgis.vcommerce.com
www.vcommerce.com
dodgeprojects.construction.com.vcommerce.com
dodgeprojects.construction.com.staging.vcommerce.com

@cschanaj

This comment has been minimized.

Sign in to view
@pipboy96

This comment has been minimized.

Sign in to view
@pipboy96

This comment has been minimized.

Sign in to view
@cschanaj

This comment has been minimized.

Sign in to view
@pipboy96

This comment has been minimized.

Sign in to view
@pipboy96
Copy link
Contributor

pipboy96 commented May 8, 2019

Personally, I allow pushing to my branch, with the exception of force-pushing. This is unlikely to change.

pipboy96
pipboy96 suggested changes May 8, 2019
View reviewed changes
Copy link
Contributor

@pipboy96 pipboy96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

src/chrome/content/rules/Vcommerce.com.xml Show resolved Hide resolved
src/chrome/content/rules/Vcommerce.com.xml Show resolved Hide resolved
src/chrome/content/rules/Vcommerce.com.xml Show resolved Hide resolved
pipboy96
pipboy96 approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@pipboy96 pipboy96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zoracon
zoracon approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@zoracon zoracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zoracon zoracon merged commit 00295e1 into EFForg:master May 9, 2019
@cschanaj cschanaj deleted the vcommerce.com branch May 9, 2019 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pipboy96 pipboy96 pipboy96 approved these changes

@zoracon zoracon zoracon approved these changes

Assignees
No one assigned
Labels
amazon-s3-2020 Bare s3.amazonaws.com domain deprecation, see #17912 ruleset-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cschanaj @pipboy96 @zoracon