This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Show only rulesets which performed an upgrade #17047
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect of #17010, the popup no longer shows rulesets which do not perform any upgrade on HTTPS pages, this PR makes it the default behavior on HTTP pages as well. It also introduce room for performance improvement like #16951.
There was concerns that users might need granular control of all the ruleset states to avoid site breakages, but #16546 is merged so I guess this is less likely an issue.
A controversial side effect could be the fact that
default_off
rulesets will not be visible anymore. That's why I have closed #16951 before #17010 emerged.cc @Hainish @jsha @zoracon @Bisaloo @J0WI @jeremyn for opinions