This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Add Option UI to Enable MCB Rulesets Globally #15070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschanaj
changed the title
cschanaj
changed the title
|
ping @Hainish for reviews and comments. |
Hainish
suggested changes
Apr 6, 2018
| <!ENTITY https-everywhere.options.importSettings "Import Settings"> | ||
| <!ENTITY https-everywhere.options.import "Import"> | ||
| <!ENTITY https-everywhere.options.showCounter "Show Counter"> |
There was a problem hiding this comment.
This was initially in the menu for the old XPCOM extension, which is why it is under the "menu" section. However, changing it to reflect the latest location will clear existing translations, since it is will be tagged by another variable name in transifex. I'd keep it how it was.
|
@Hainish done. thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow advanced users to enable
mixedcontentrulesets easily and globally, it should be particularly useful inBlock all unencrypted requestsmode where MCB is expected and resolved in #14600Basic testings were performed by visiting https://www.wwf.or.jp/ (which has a
mixedcontentrules)WWF.or.jpshown up inExperimental rulesand uncheckedWWF.or.jpshown up inStable rulesand checkedRelated: /issues/9971, https://trac.torproject.org/projects/tor/ticket/21323
Re-open #15069