Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Merge, disable WinZip.com related rulesets #10265

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Merge, disable WinZip.com related rulesets #10265

merged 1 commit into from
Aug 2, 2017

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented Jun 9, 2017

#9842 Remove rule for *winzip.com because of its limited support.

  • www redirects to HTTP on $ and serves some active mixed content on other paths.
  • ^ redirects to www.
  • store redirects to support.cleverbridge.com

See https://gist.github.com/cschanaj/ef7da481b2fb84e3acfe15fc94a11a97 for the status of other non-functional sub-domains. Thanks.

@J0WI
Copy link
Contributor

J0WI commented Jul 29, 2017

I feel always uncomfortable with removing non-working rulesets like this, because I always hope that they will fix it one day.

@cschanaj
Copy link
Collaborator Author

Sadly, it always take a long time (or even forever) for site like this moving to HTTPS. In some case, they even prefer to redirect everything over HTTPS to plaintext in order to avoid the hassle of migrating.

In this particular case, www is causing infinite loop issues on mixedcontent platform (see https://www.winzip.com/win/en/). So I guess they are moving away from HTTPS. If you prefer to keep this rule, I can rebase to default_off both ruleset in this PR.

@J0WI
Copy link
Contributor

J0WI commented Jul 29, 2017

I hope that sites are forced to move to HTTPS anyway, because of the penalty by browsers and search engines.

So let's just disable it.

@cschanaj cschanaj changed the title Delete WinZip.com.xml and WinZip.com-falsemixed.xml Disable WinZip.com-falsemixed.xml Jul 29, 2017
@cschanaj
Copy link
Collaborator Author

cschanaj commented Jul 29, 2017

@J0WI done. thanks! @Bisaloo please be noted that this PR does not remove the duplicated entry in the whitelist. thanks!

For rules not causing false/broken MCB, see WinZip.com.xml.

www redirects to plaintext, e.g. https://www.winzip.com/win/en/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the fact, that this redirect is JS based.

@J0WI
Copy link
Contributor

J0WI commented Jul 30, 2017

You can still merge the rulesets, they are both default off anyway.

@cschanaj cschanaj changed the title Disable WinZip.com-falsemixed.xml Merge, disable WinZip.com related rulesets Jul 30, 2017
@cschanaj
Copy link
Collaborator Author

cschanaj commented Aug 2, 2017

@J0WI rebased accordingly, thanks!!

@J0WI J0WI merged commit f44161f into EFForg:master Aug 2, 2017
@cschanaj cschanaj deleted the winzip.com branch August 2, 2017 22:18
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants