-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve find_modules with regex functionality #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar expression. It can also ommit the version (i.e. anything after the last slash) from the match, if required.
smoors
reviewed
Aug 26, 2023
Forward slash does not need to be escaped Co-authored-by: Sam Moors <[email protected]>
smoors
reviewed
Aug 28, 2023
smoors
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works fine (after removing the trailing slash with name_only=True, see comment).
Co-authored-by: Sam Moors <[email protected]>
Co-authored-by: Sam Moors <[email protected]>
…with name_only=True
…nto find_modules_regex
smoors
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand functionality of find_modules so that it can be passed a regular expression. It can also ommit the version (i.e. anything after the last slash) from the match, if required.
If you want to define a ReFrame test to play around with the new
find_modules
functionality:Then run with e.g.
This also makes me think: do we need unittests for the test suite? I.e. tests that test the
hooks
&utils
? It might be difficult to make some of those, e.g. how do we convince the ReFrame runtimesavailable_modules
to return us a predetermined set of modules? But it would be worthwhile to have, as it defines the desired behaviour. It would also be very valuable for things like: does filtering work (which tests should run on which partitions), how many MPI ranks & OpenMP threads are launched, etc.