first attempt at a common staging class #209
Conversation
|
|
||
|
|
||
| @rfm.simple_test | ||
| class EESSI_CP2K(rfm.RunOnlyRegressionTest, EESSI_Mixin): | ||
|
|
||
| stage_files = fixture(EESSI_CP2K_stage_input, scope='session') | ||
| srcdir = os.path.join(os.getcwd(), 'cp2k_staging', 'src') | ||
| stage_files = fixture(EESSI_Staging, scope='session', variables={'sourcesdir': srcdir}) |
There was a problem hiding this comment.
I'm not sure if this will work. If another test uses EESSI_Staging as a fixture, with scope session, will it then be run twice (i.e. once for each tests invoking it as a fixture)? Or once (because it's once per session scope)?
Also: even if it does run once per test that invokes this as fixture, it'll have the name EESSI_Staging both times, right? That could be confusing. But maybe that can be resolved by overwriting the test name through the variables construct? I don't know, I don't have much experience with variables as an argument to fixture.
Could you try to add the lammps case here as well? That would allow us to easily verify it.
There was a problem hiding this comment.
Discussed in the meeting: maybe we can do something along the lines of:
stage_files = fixture(EESSI_Staging, scope='session', variables={'sourcesdir': srcdir, 'testname': testname + '_staging'})
update: also added a test-agnostic sanity check to the staging class