Skip to content

Commit

Permalink
Updated hook name, and make the description a bit more clear
Browse files Browse the repository at this point in the history
  • Loading branch information
Caspar van Leeuwen committed Feb 5, 2024
1 parent b52fd19 commit f5339a7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions eessi/testsuite/hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ def _assign_one_task_per_gpu(test: rfm.RegressionTest):
log(f'num_tasks set to {test.num_tasks}')


def filter_valid_test_scales(test: rfm.RegressionTest):
def filter_supported_scales(test: rfm.RegressionTest):
"""
Request the test scale as feature. That we the test will not be generate for partitions that don't support this test scale.
Filter tests scales based on which scales are supported by each partition in the ReFrame configuration. Filtering is done using features. I.e. the current test scale is requested as a feature. Any partition that does not include this feature in the ReFrame configuration file will effectively be filtered out.
"""
valid_systems = f'+{test.scale}'
# test.valid_systems wasn't set yet, so set it
Expand Down
4 changes: 2 additions & 2 deletions eessi/testsuite/tests/apps/gromacs.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ class GROMACS_EESSI(gromacs_check):
def run_after_init(self):
"""Hooks to run after the init phase"""

# Filter invalid sizes
hooks.filter_valid_test_scales(self)
# Filter on which scales are supported by the partitions defined in the ReFrame configuration
hooks.filter_supported_scales(self)

# Make sure that GPU tests run in partitions that support running on a GPU,
# and that CPU-only tests run in partitions that support running CPU-only.
Expand Down

0 comments on commit f5339a7

Please sign in to comment.