-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstall glibc in playbook #87
Conversation
Done. |
Maybe it would also be nice if this step could check if it has already been run before. |
@bedroge We should also add a check to make sure that the |
@bedroge Tests fail with:
|
Yep, but I wanted to do that in some test script/suite that gets run by Ansible and/or a Github Action, see #42.
Hmm... I've seen that before on a local test: glibc fails to install, because of wrong settings in |
Though that doesn't really work, since we also need to have our overlay added (which has the configuration files for the custom |
Okay, I shuffled the steps a bit, so that this step get executed before the symlinks to the hosts are created. There's also a check now that does a grep for our defined dir on the libc library, so that this step only gets executed once. I'm now passing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks passed :-( i was too fast
@peterstol I was making some last/small improvements, but then the lint ci started complaining ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd attempt...
Add 2023.02 sets
Fixes EESSI/gentoo-overlay#7.
I've added this as a separate step in
install_packages.yml
, as it requiresnoreplace: no
, and I don't want to reinstall our entire set every time we (re)run this playbook. Also settingoneshot: yes
to preventglibc
from being added to theworld
file.We need another PR in https://github.com/EESSI/gentoo-overlay to remove
glibc
from the set.