-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build compat layer software.eessi.io/2023.06 #191
Conversation
- changed repository name to software.eessi.io - fixed creation of tarball at the end of `bot/build.sh` - should be improved to handle errors when some tmp directory couldn't be determined - added `bot/check-build.sh` that prepares `.result` file including a status update for the PR comment - added a bit more debug output in `install_compatibility_layer.sh`, should help with setting up debug sessions Not changed CI `pilot_repo.yml` yet.
Instance
|
bot: build arch:generic repo:compat |
Updates by the bot instance
|
New job on instance
|
New job on instance
|
The building "worked", the task that failed was the ReFrame test at the end. This tests (among other things) if a Reconfigured the bot to be able to build for two repositories bot: show_config |
Updates by the bot instance
|
Instance
|
bot: build arch:generic repo:eessi.io-2023.06-compat |
Updates by the bot instance
|
New job on instance
|
New job on instance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trz42 Just two small comments, but other than that I guess it's ready to be merged?
# eessi_os=linux | ||
job_version=$(cfg_get_value "repository" "repo_version") | ||
eessi_version=${job_version:-2023.09} | ||
# job_repo=$(cfg_get_value "repository" "repo_name") | ||
# eessi_repo=${job_repo:-pilot.nessi.no} | ||
# tar_topdir=/cvmfs/${eessi_repo}/versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these commented lines be removed?
summary=":cry: FAILURE" | ||
fi | ||
|
||
# TODO adjust format to what NESSI bot uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what needs to happen here, but this mentions NESSI? Can it be removed, or is there still something that needs to be changed?
I prefer to have this merged, to avoid surprises going forward, since this is active in If any cleanup is still required, it can be done in a subsequent PR... |
bot/build.sh
bot/check-build.sh
that prepares.result
file including a status update for the PR commentinstall_compatibility_layer.sh
, should help with setting up debug sessionsDid not change CI
pilot_repo.yml
yet.